Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quarkus:test Re-run failed tests does not run failed ParameterizedTest #23937

Closed
RuggeroDAlo opened this issue Feb 24, 2022 · 1 comment · Fixed by #23959
Closed

quarkus:test Re-run failed tests does not run failed ParameterizedTest #23937

RuggeroDAlo opened this issue Feb 24, 2022 · 1 comment · Fixed by #23959
Labels
Milestone

Comments

@RuggeroDAlo
Copy link
Contributor

RuggeroDAlo commented Feb 24, 2022

Describe the bug

In Continuous Testing mode tests that use @ParameterizedTest with @ValueSource like this:

@QuarkusTest
public class GreetingResourceTest {

    @ParameterizedTest
    @ValueSource(strings = {"fail"})
    public void parametrizedTest(String input) {
        assertEquals("ok", input);
    }

}

are not rerun when a "Re-run failed tests" command is issued, but All tests are now passing is shown instead.

Expected behavior

ParameterizedTest tests that fail should be rerun

Actual behavior

ParameterizedTest tests that fail are declared as passing without having been rerurn

How to Reproduce?

Declare a failing ParameterizedTest test and try to rerun it in Continuous Testing

Output of uname -a or ver

5.13.0-30-generic #33-Ubuntu SMP Fri Feb 4 17:03:31 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

Output of java -version

Java version: 11.0.13, vendor: Ubuntu, runtime: /usr/lib/jvm/java-11-openjdk-amd64

GraalVM version (if different from Java)

NA

Quarkus version or git rev

2.7.2

Build tool (ie. output of mvnw --version or gradlew --version)

Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)

Additional information

No response

@RuggeroDAlo RuggeroDAlo added the kind/bug Something isn't working label Feb 24, 2022
@RuggeroDAlo RuggeroDAlo changed the title quarkus:test Re-run failed tests does not run failed ParametrizedTests quarkus:test Re-run failed tests does not run failed ParameterizedTest Feb 24, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 24, 2022

/cc @stuartwdouglas

stuartwdouglas added a commit to stuartwdouglas/quarkus that referenced this issue Feb 25, 2022
stuartwdouglas added a commit to stuartwdouglas/quarkus that referenced this issue Feb 25, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 25, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.3.Final Feb 28, 2022
gsmet pushed a commit to gsmet/quarkus that referenced this issue Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants