Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cleanDisabled to Flyway configuration #16561

Closed
tioback opened this issue Apr 15, 2021 · 1 comment · Fixed by #16563
Closed

Add cleanDisabled to Flyway configuration #16561

tioback opened this issue Apr 15, 2021 · 1 comment · Fixed by #16563
Assignees
@tioback
Labels
area/flyway good first issue Good for newcomers kind/enhancement New feature or request
Milestone
1.13.3.Final

Comments

@tioback
Copy link
Contributor

tioback commented Apr 15, 2021

Description

As mentioned in #6240 , flyway.cleanDisabled is not currently supported by Quarkus.

It might be needed in cases where you need to run Flyway manually and need to change behaviour through configuration, instead of coding.

Implementation ideas

  • Add to io/quarkus/flyway/runtime/FlywayCreator.java:54:

    configure.cleanDisabled(flywayRuntimeConfig.cleanDisabled);

  • Add to io/quarkus/flyway/runtime/FlywayDataSourceRuntimeConfig.java:74

    /**
     * true to prevent Flyway clean operations, false otherwise.
     */
    @ConfigItem
    public boolean cleanDisabled;

I'll submit a PR later today, as soon as Quarkus dependencies finish downloading 🤣 .
@tioback tioback added the kind/enhancement New feature or request label Apr 15, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Apr 15, 2021

/cc @cristhiank, @gastaldi, @geoand, @gsmet

@gastaldi gastaldi added the good first issue Good for newcomers label Apr 15, 2021
tioback added a commit to tioback/quarkus that referenced this issue Apr 15, 2021
@tioback
Adds cleanDisabled to Flyway configuration. Fixes quarkusio#16561.
d9bad8a
@tioback tioback mentioned this issue Apr 15, 2021
Merged
tioback added a commit to tioback/quarkus that referenced this issue Apr 15, 2021
@tioback
Adds cleanDisabled to Flyway configuration. Fixes quarkusio#16561.
9aa6d6f
@quarkus-bot quarkus-bot bot added this to the 2.0 - main milestone Apr 20, 2021
@gsmet gsmet modified the milestones: 2.0.0.Alpha1, 1.13.3.Final Apr 26, 2021
gsmet pushed a commit to gsmet/quarkus that referenced this issue Apr 26, 2021
@tioback @gsmet
Adds cleanDisabled to Flyway configuration. Fixes quarkusio#16561.
6eae216 
(cherry picked from commit 9aa6d6f)
gsmet pushed a commit to gsmet/quarkus that referenced this issue Apr 26, 2021
@tioback @gsmet
Adds cleanDisabled to Flyway configuration. Fixes quarkusio#16561.
3484af3 
(cherry picked from commit 9aa6d6f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tioback tioback

Labels
area/flyway good first issue Good for newcomers kind/enhancement New feature or request
Projects
None yet
Milestone
1.13.3.Final
Development

Successfully merging a pull request may close this issue.

Adds cleanDisabled to Flyway configuration tioback/quarkus
3 participants
@gastaldi @gsmet @tioback