Enhance RestClient Reactive to support registering providers via custom annotations

[sberyozkin]

Description

The following is possible with quarkus-rest-client, for example, with OidcClientRequestFilter

@Inject
@OidcClientFilter
MyMpRestClient client;

where the quarkus-oidc-client-filter extension registers OidcClientFilter annotation and OidcClientRequestFilter.class pair, and where quarkus-rest-client's RestClientProcessor discovers such registrations and passes them to RestClientBase.

Note as far as OidcClientRequestFilter is concerned, the alternative solution (explicitly register it with MP RestClient RegisterProvider) is available. This issue is not about OidcClientRequestFilter but about a generic support for registering providers via custom annotations.

Implementation ideas

Do something similar in the reactive rest client to what is done in quarkus-rest-client's RestClientProcessor and RestClientBase.

[geoand]

cc @michalszynkiewicz

[quarkus-bot]

/cc @michalszynkiewicz

[rsvoboda]

I'm looking into migration of an app that is using quarkus-oidc-client-filter and quarkus-oidc-token-propagation to their reactive variants

Change of extensions doesn't work, code doesn't compile as it is using io.quarkus.oidc.client.filter.OidcClientFilter and io.quarkus.oidc.token.propagation.AccessToken. Those classes are not available in quarkus-oidc-client-reactive-filter and quarkus-oidc-token-propagation-reactive.

Unfortunately it is not possible for RESTEasy Reactive because of this issue.
So with the new reactive options one needs to reg the providers directly for now: https://quarkus.io/guides/security-openid-connect-client-reference#oidc-client-reactive-filter and https://quarkus.io/guides/security-openid-connect-client-reference#reactive-token-propagation

This makes transition to quarkus-oidc-client-reactive-filter and quarkus-oidc-token-propagation-reactive harder / damages user experience a bit.

[rsvoboda]

/cc @geoand @Sgitario

[geoand]

@sberyozkin what's your take on #16522 (comment)? Is there something we need to do to make the experience better? Or maybe just add some more documentation?

[sberyozkin]

Hey @geoand, apologies, I've just discovered your comment after following on the related comments from Rostislav in QUARKUS-2389.

I think that if RestEasy Reactive could allow supporting the same style of registering OIDC Reactive client filter as the one allowed in RestEasy Classic for OIDC client,

@Inject
@OidcClientFilter
MyMpRestClient client;

in addition to the standard

@Inject
@RegisterProvider(OidcClientRequestReactiveFilter.class)
MyMpRestClient client;

then it would indeed be a bit nicer and as @rsvoboda has indicated, would not even require the code changes during the migration to Resteasy Reactive which Rostislav is quite concerned about.

Have a look at the description please - I've provided links to the RestEasy Classic code showing how @OidcClientFilter is recognized and processed to get (classic) OidcClientFilter registered, I can try to do pretty much the same but in RestEasy Reactive, but I'd appreciate some help. May be Jose can be interested as well ?

thanks

[geoand]

Thanks @sberyozkin, I'll have a look next week.

[sberyozkin]

For example, oidc-client-filter registers a pair of @OidcClientFilter and the associated provider class name here, and then RestEasy Classic checks the list of these build items and if a given REST Client has a matching annotation then the associated provider is added, so it should be simple enough I guess to do the same with RestEasy Reactive :-), and then once this is in place, the users can have their custom extensions provide such annotation shortcuts for their providers as well

[sberyozkin]

@geoand Np at all, yeah, lets see if it can be done without too many problems, ping me please if you'd like me to help somehow, cheers

[geoand]

👍🏼

[geoand]

@sberyozkin can you take a look at #28451?

It should cover this

[sberyozkin]

Hey @geoand what a good Friday, sorry, had to step outside for a very late lunch :-)

[geoand]

No problem at all :)