Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"quarkus.container-image.*" entries not showing in the "All Configuration Options" guide. #12316

Closed
someth2say opened this issue Sep 24, 2020 · 6 comments · Fixed by #12323
Closed
Labels
area/documentation kind/bug Something isn't working
Milestone

Comments

@someth2say
Copy link
Contributor

Describe the bug
When looking for "container-image" entries in the "All Configuration Options guide", the only entries that appear are some "quarkus.knative" and "quarkus.openshift" entries, as they default to "quarkus.container-image" values.
No entry for "quarkus.container-image" is shown.

Expected behavior
Include the "quarkus.container-image" entries like in https://quarkus.io/guides/container-image#container-image-options

Actual behavior
Expected entries not show.

To Reproduce
Steps to reproduce the behavior:

  1. Go to "https://quarkus.io/guides/all-config" and wait for the complete page to load.
  2. Type "container-image" in the search box.

Configuration
N/A

Screenshots
image

Environment (please complete the following information):
N/A

Additional context
https://quarkusio.zulipchat.com/#narrow/stream/187038-dev/topic/.22quarkus.2Econtainer-image.2E*.22.20not.20in.20the.20all-configs.20guide

@someth2say someth2say added the kind/bug Something isn't working label Sep 24, 2020
@geoand geoand assigned geoand and unassigned geoand Sep 24, 2020
@geoand
Copy link
Contributor

geoand commented Sep 24, 2020

@machi1990 any idea why this is happening?

@machi1990
Copy link
Member

@machi1990 any idea why this is happening?

Hi @geoand, I've not checked into details but I suspect that it could be same issue as #5214

@geoand
Copy link
Contributor

geoand commented Sep 24, 2020

That's weird :)

If you have to look into this, it would be great. Otherwise, I'll add it to my queue :)

@machi1990
Copy link
Member

That's weird :)

If you have to look into this, it would be great. Otherwise, I'll add it to my queue :)

A quick fix I can think of is to add an empty container-image runtime module to make the container-image-deployment recognizable as an extension. The empty module could contain the extension.yml file with the unlisted:true metadata for it to not be published.

@machi1990
Copy link
Member

That's weird :)
If you have to look into this, it would be great. Otherwise, I'll add it to my queue :)

A quick fix I can think of is to add an empty container-image runtime module to make the container-image-deployment recognizable as an extension. The empty module could contain the extension.yml file with the unlisted:true metadata for it to not be published.

@geoand I can open a draft PR for you to have a quick look. WDYT?

@geoand
Copy link
Contributor

geoand commented Sep 24, 2020

That would be great, thanks!

machi1990 added a commit to machi1990/quarkus that referenced this issue Sep 24, 2020
machi1990 added a commit to machi1990/quarkus that referenced this issue Sep 24, 2020
machi1990 added a commit to machi1990/quarkus that referenced this issue Sep 24, 2020
machi1990 added a commit to machi1990/quarkus that referenced this issue Sep 24, 2020
@gsmet gsmet modified the milestones: 1.9.0 - master, 1.8.2.Final Oct 1, 2020
gsmet pushed a commit to gsmet/quarkus that referenced this issue Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation kind/bug Something isn't working
Projects
None yet
4 participants