Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Cloud services extension pack 1.0.0 #457

Merged
merged 1 commit into from Jan 31, 2022

Conversation

loicmathieu
Copy link
Contributor

When I launchd mvn -Dsyn it updates more than 200 pom with artifactid and groupId inverted !

I didn' commit all of them so I manually include only the changes made to version and new libraires on the 4 files that are usually udated when I update the platform for the Google Cloud services extensions.

As I may miss some changes in one of those 200 pom, maybe it would be better if someone can validate my PR locally (or just sync the platform after merging it).

Sorry for that :(

@aloubyansky
Copy link
Member

@loicmathieu it's probably because you used mvn instead of the wrapper from the project.

@loicmathieu
Copy link
Contributor Author

Well, I never use the wrapper ...

Let's wait for Monday so I can launch with the wrapper and be sure to catch all modifications.

@loicmathieu
Copy link
Contributor Author

And looking at the CI status there is missing modifications.

@gsmet
Copy link
Member

gsmet commented Jan 29, 2022

For the record: they changed how things were generated between two micro versions of Maven. That's why we use the wrapper now to make sure things stay consistent.

@gsmet gsmet merged commit f309e0c into quarkusio:main Jan 31, 2022
@gsmet
Copy link
Member

gsmet commented Jan 31, 2022

Thanks!

@loicmathieu loicmathieu deleted the google-cloud-services-1-0-0 branch July 21, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants