Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StringSwitch - fix hashCode collisons #146

Merged
merged 1 commit into from Jan 4, 2023
Merged

StringSwitch - fix hashCode collisons #146

merged 1 commit into from Jan 4, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jan 4, 2023

  • the previous impl should be functionally equivalent but less efficient if a tested value has the same hashCode as one of the labels but none of the labels is equal to the tested value

@mkouba
StringSwitch - fix hashCode collisons
f51bebd 
- the previous impl should be functionally equivalent but less efficient
if a tested value has the same hashCode as one of the labels but none of
the labels is equal to the tested value
@mkouba
Copy link
Contributor Author

mkouba commented Jan 4, 2023

@Ladicek I'm sorry but I have one more fix related to the StringSwitch ;-)

@mkouba mkouba requested a review from Ladicek January 4, 2023 15:26
@Ladicek
Copy link
Contributor

Ladicek commented Jan 4, 2023

You're keeping me busy 😆

@Ladicek Ladicek merged commit ab1c927 into quarkusio:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkouba @Ladicek