Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String/Enum switch - make result handles from enclosing scope accesible #144

Merged
merged 1 commit into from Jan 4, 2023
Merged

String/Enum switch - make result handles from enclosing scope accesible #144

merged 1 commit into from Jan 4, 2023

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Jan 4, 2023

Follows up on #143.

@mkouba mkouba requested a review from Ladicek January 4, 2023 12:30
@Ladicek
Copy link
Contributor

Ladicek commented Jan 4, 2023

I was wondering why did the previous version call findActiveResultHandles, but didn't quite realize it should override the method instead. Good catch!

@Ladicek Ladicek merged commit 1185f56 into quarkusio:main Jan 4, 2023
@mkouba
Copy link
Contributor Author

mkouba commented Jan 4, 2023

I was wondering why did the previous version call findActiveResultHandles, but didn't quite realize it should override the method instead. Good catch!

To be honest I'm still a bit unsure but the tests pass so it should be fine ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ladicek Ladicek Ladicek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkouba @Ladicek