Allow to configure the reaction strategy #356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #351
@lppedd here is the PR. For your use case, I recommend you use
ReactionStrategy.ON_PROGRESS_ON_ERROR
. It will handle the rocket and also the potential parse errors (and potential exceptions that you might not catch).Anyway, I will let you experiment with the options and report back. I will release a 1.12.0 tonight and will iterate from there.