DependencyChecker: Reuse resolveSync() method on Project class
#94
+8
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow EmberCLI to implement Yarn PnP support without the dependency checker having to care about the details
rwjblue
approved these changes
Jan 2, 2019
|
ember-cli-dependency-checker 3.1.0 published 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow EmberCLI to implement Yarn PnP support without the dependency checker having to care about the details.
The other use of
resolvein theShrinkwrapCheckerclass seems irrelevant to this, as it is only used when npm shrinkwrap is used, and in that case it seems unlikely that Yarn PnP is used in parallel.Resolves #92
/cc @rwjblue @quaertym