Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed package is not recognized #17

Closed
indirect opened this issue Jan 5, 2015 · 7 comments
Closed

Installed package is not recognized #17

indirect opened this issue Jan 5, 2015 · 7 comments

Comments

@indirect
Copy link

indirect commented Jan 5, 2015

I just upgraded to Ember 1.10 beta by adding "ember": "~1.10.0" to bower.json. I ran bower install, and everything installed. But the dependency checker fails when I try to start ember-cli:

$ ember s
version: 0.1.4

Missing bower packages: 
Package: ember
  * Specified: ~1.10.0
  * Installed: 1.10.0-beta.3

Please recognize packages that are correctly installed and meet the requested dependencies.

(tested on ember-cli-dependency-checker version 0.0.6 and 0.0.7)

@quaertym
Copy link
Owner

quaertym commented Jan 6, 2015

Have you tried specifying it as 1.10.0-beta.3 in your bower file?

@indirect
Copy link
Author

indirect commented Jan 6, 2015

Why would that be required? Bower installed a version that meets my requirement, and now I'm being told "not really".

On Mon, Jan 5, 2015 at 4:57 PM, Emre Unal notifications@github.com
wrote:

Have you tried specifying it as 1.10.0-beta.3 in your bower file?

Reply to this email directly or view it on GitHub:
#17 (comment)

@quaertym
Copy link
Owner

quaertym commented Jan 6, 2015

This line semver.satisfies('1.10.0-beta.3', '~1.10.0') returns false and I agree that beta version does not satisfy the stable 1.10.0 version. I guess bower tries to do best match. You can manifest this dependency as "ember": ">1.10.0-beta.1" or open an issue for bower or semver.

@indirect
Copy link
Author

indirect commented Jan 6, 2015

Then please change the message to stop saying "run bower install to install missing dependencies", because that is false.

On Tue, Jan 6, 2015 at 5:22 AM, Emre Unal notifications@github.com
wrote:

This line semver.satisfies('1.10.0-beta.3', '~1.10.0') returns false and I agree that beta version does not satisfy the stable 1.10.0 version. I guess bower tries to do best match. You can manifest this dependency as "ember": ">1.10.0-beta.1" or open an issue for bower or semver.

Reply to this email directly or view it on GitHub:
#17 (comment)

@quaertym
Copy link
Owner

quaertym commented Jan 9, 2015

The current version assumes the manifest is correct.

@quaertym quaertym closed this as completed Jan 9, 2015
@indirect
Copy link
Author

indirect commented Jan 9, 2015

That's not the point; the error message is misleading (and flat out wrong in this case). It's extremely user-hostile to throw an error that says "fix this error by running bower install" but running bower install doesn't fix the error. This is the kind of thing that makes people give up on using Ember at all.

@quaertym
Copy link
Owner

quaertym commented Jan 9, 2015

This is going to be handled by another feature. See #16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants