Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for PHP 8? #25

Open
tappenden opened this issue Jul 16, 2021 · 3 comments
Open

Support for PHP 8? #25

tappenden opened this issue Jul 16, 2021 · 3 comments

Comments

@tappenden
Copy link

Is support for PHP 8 going to be added? It's not clear if the codebase has PHP 8 breaks or if this is simply a Composer dependencies issue.

@QassaDevelopers
Copy link

I did create a PR for php 8 support. By the looks of it, and according to the tests, only composer needed change (and the Dockerfile).
Feedback is welcome.

#26

@tappenden
Copy link
Author

Sorry for the slow response, I've been occupied elsewhere.

I can't get Composer to use the relevant commit. I have included the repository in composer.json.

Your requirements could not be resolved to an installable set of packages.

Problem 1
- Root composer.json requires qpautrat/woohoolabs-yin-bundle dev-master#b001686f63ac8a5769cb7704bced2c9509a7129e -> satisfiable by qpautrat/woohoolabs-yin-bundle[dev-master].
- qpautrat/woohoolabs-yin-bundle dev-master requires php ^7.1.0 -> your php version (8.0.9) does not satisfy that requirement.

@fractalzombie
Copy link

This is so bad practice to update your library once in 3 years…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants