Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package annotation Collector #1190

Open
ariddlestone opened this issue May 23, 2023 · 2 comments
Open

Add package annotation Collector #1190

ariddlestone opened this issue May 23, 2023 · 2 comments

Comments

@ariddlestone
Copy link
Contributor

Can we add a collector which looks for a particular @package annotation from a class-like's docblock to include it in a layer?

It would be really handy for one of my current projects, and I'd be happy to give it a go and produce a PR.

@patrickkusebauch
Copy link
Collaborator

You should be able to do this yourself following https://github.com/qossmic/deptrac/blob/main/docs/extending_deptrac.md#layer-collectors, It should have everything you might need to implement this.

@ariddlestone
Copy link
Contributor Author

ariddlestone commented May 29, 2023

I've started down this path (a separate collector, outside deptrac), but am having to use qossmic/deptrac rather than deptrac-shim because of #916, and thought it might be useful outside our project.

I'll put together a PR.

ariddlestone added a commit to ariddlestone/deptrac that referenced this issue May 29, 2023
ariddlestone added a commit to ariddlestone/deptrac that referenced this issue Jun 10, 2023
ariddlestone added a commit to ariddlestone/deptrac that referenced this issue Jul 12, 2023
ariddlestone added a commit to ariddlestone/deptrac that referenced this issue Jul 12, 2023
ariddlestone added a commit to ariddlestone/deptrac that referenced this issue Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants