New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

putCloseable should not remove the key from MDC if it was previously set to a different value #404

Open

mdpearson opened this issue Mar 15, 2024 · 0 comments · May be fixed by #405

mdpearson commented Mar 15, 2024

Our team wrote some code that broadly looked like this:

MDC.put("color", "red");

try(ignored = MDC.putCloseable("color", "green")) {
...
}

assertTrue(MDC.get("color", "green")) // fails, the key is deleted

It should be an easy patch to allow callers to nest putCloseable calls and get expected results; in fact, I'll go try to write one now.

Thank you very much, by the way, for SLF4j -- it's a wonderful tool. Cheers

The text was updated successfully, but these errors were encountered:

mdpearson linked a pull request

that will close this issue

Support nested putCloseable invocations (issues/404) #405

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment