Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The compatibility about 1.7.36 & 2.x #370

Open
hw207165 opened this issue Dec 2, 2023 · 3 comments
Open

The compatibility about 1.7.36 & 2.x #370

hw207165 opened this issue Dec 2, 2023 · 3 comments

Comments

@hw207165
Copy link

hw207165 commented Dec 2, 2023

Are there any compatibility issues when we need to upgrade slf4j from 1.7.36 to 2.x?

@KengoTODA
Copy link
Contributor

You may refer: https://www.slf4j.org/faq.html#changesInVersion200

@hazendaz
Copy link
Contributor

hazendaz commented Dec 2, 2023

Biggest issue is if you are using spring boot 2. Its possible to turn off spring boots logging and use 2 though but its not straight forward and spring hasn't exactly helped there. You can find that info in their issues if you dig deep enough.

What I dislike in general was fact that slf4j went major to 2.x while logback was left minor on 1.3 (javax namespace) and 1.4 (jakarta namespace). That part is the most problematic because the bots (renovate, synk, dependabot, others) treat 1.3 and 1.4 the same by default and suggest premature upgrades to 1.4.x. The only saving grace if any was the level of CVEs on logback this week that caused the bots to send targeted releases but those were already deemed buggy and not complete. So a lot of manual work :(

Should you upgrade? Yes, it took years if I recall to get here. So long as you don't have spring boot consideration, there is no question just upgrade. As long as your configuration was not outrageous on requirements, its basically drop in place. In fact, for the some 2k repos I support, I don't recall any considerations outside of spring boot. And even there we upgraded some of those to latest on 2.7.x with various solutions found within spring boot issues.

@ceki
Copy link
Member

ceki commented Dec 2, 2023

In addition to the link @KengoTODA mentioned, there is also Are SLF4J versions backward compatible? FAQ entry which you might want to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants