Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing javadoc to SLF4JServiceProvider.java #310

Merged
merged 1 commit into from Sep 25, 2022

Conversation

ascopes
Copy link
Contributor

@ascopes ascopes commented Sep 25, 2022

Had to do some digging around the logback-classic alpha release for SLF4J2 API integration to work out the nature of this behaviour. This should prevent confusion for developers of other logging implementations in the future.

@ascopes
Copy link
Contributor Author

ascopes commented Sep 25, 2022

Assuming I shouldn't be the one to mark that sign-off on the commit?

If I need to do anything else, please let me know :)

@ceki
Copy link
Member

ceki commented Sep 25, 2022

Assuming I shouldn't be the one to mark that sign-off on the commit?

In fact, the sign-off is a Developer Certificate of Origin. So, the sign-off must be performed by the contributor, i.e. in this case, by you .

@ascopes
Copy link
Contributor Author

ascopes commented Sep 25, 2022

@ceki got it! Will sort that out now, thanks

Edit: updated. Thanks.

Had to do some digging around the logback-classic alpha release for SLF4J2 API
integration to work out the nature of this behaviour. This should prevent confusion
for developers of other logging implementations in the future.

Signed-off-by: Ashley Scopes <73482956+ascopes@users.noreply.github.com>
@ceki ceki merged commit 7686020 into qos-ch:master Sep 25, 2022
@ascopes ascopes deleted the patch-1 branch September 25, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants