Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automatic module name #58

Merged
merged 1 commit into from Nov 21, 2022
Merged

Added automatic module name #58

merged 1 commit into from Nov 21, 2022

Conversation

robtimus
Copy link
Contributor

The current version of reload4j does not define any module name. That prevents adding it as a proper dependency in module descriptor. If you do, using the automatic module name based on the JAR file name (reload4j), the following warning is shown:

[WARNING] *******************************************************************************************************************************************
[WARNING] * Required filename-based automodules detected: [reload4j-1.2.22.jar]. Please don't publish this project to a public artifact repository! *
[WARNING] *******************************************************************************************************************************************

This PR sets an explicit automatic module name. Since all of reload4j's own dependencies are a) optional and b) have versions with proper module names, this allows module descriptors to use the new automatic module name (ch.qos.reload4j) without any warnings or other issues.

@ceki ceki merged commit aa5e918 into qos-ch:master Nov 21, 2022
@robtimus robtimus deleted the automatic-module-name branch November 21, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants