[LOGBACK-1409] FileFilterUtil.filesInFolderMatchingStemRegex resuses compiled pattern #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlosna
force-pushed
the
ds/file-filter-regex
branch
from
a141401
to
f8b9369
Compare
schlosna
changed the title
FileFilterUtil.filesInFolderMatchingStemRegex resuses compiled pattern to avoid expensive regex recompilation for each file comparison. Signed-off-by: David Schlosnagle <davids@palantir.com>
schlosna
force-pushed
the
ds/file-filter-regex
branch
from
f8b9369
to
ac823db
Compare
|
Hi @ceki , I am curious if you would consider this PR. |
|
@schlosna Thank you for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LOGBACK-1409
While reviewing some JFR from a service using logback, I noticed some significant allocations and processing being done by
ch.qos.logback.core.rolling.helper.FileFilterUtil$3.accept(File, String)where it was recompiling a regex for each listed file as part of the FileFilter.This PR compiles the pattern once and reuses it for each file.