Prevent replacement of properties

[reitzmichnicht]

I don't know which version introduced the changed behaviour. I'm using version 8.0.0 now and I have a section like this in the pom.xml

<properties>
<project.build.outputTimestamp>${git.commit.timestamp.datetime}</project.build.outputTimestamp>
</properties>

Everytime I run mvn commands like this:
mvn versions:set -DnewVersion=1.2.3-SNAPSHOT
The placeholder is replaced with the timestamp in the original pom.xml although I have not enabled any updatePom setting.

[qoomon]

That is strange, I'll investigate.

[qoomon]

I was able to reproduce your bug. Give me some days and I'll try fixing it

[qoomon]

It turns out this behaviour is not caused by the maven-git-versioning-extension. If I run mvn versions:set -DnewVersion=1.2.3 and the pom version was not equals to 1.2.3 and there is a <project.build.outputTimestamp> property defined than this property gets set by the maven versions plugin.

[qoomon]

This versions-maven-plugin behaviour was introduced by this merge mojohaus/versions#522. So this behaviour is pretty new.

[qoomon]

I'm thinking about implement the same logic. Means override <project.build.outputTimestamp> with commit timestamp, if property is present. So you don't have to have a property like <project.build.outputTimestamp>${git.commit.timestamp.datetime}</project.build.outputTimestamp>.

WDYT?

BTW I plan to remove basically all ${git....} properties, because they are not resolved by default and therefore their values are not part of the published pom.xml. Instead you should make use of the <properties> within the extension config file e.g.

<ref type="branch">
    <pattern>.+</pattern>
    <version>${ref}-SNAPSHOT</version>
    <properties>
        <foo>${commit.timestamp.datetime}</foo>
    </properties>
</ref>

[reitzmichnicht]

Sorry about filling non related bugs here, but thanks for the investigation. Always a joy to see new features introduced with changing the old defaults.

For me it would also be fine to define/use the git properties via the extension config.
With the release process our highest problem is that we still want to use some checks of the release:prepare step and that this relies on a snapshot version defined, so the whole process is segregated into steps with this extension enabled/disabled

Kind regards,
Michael

[qoomon]

Following merge of the version plugin adds an option to set behaviour of updating of project.build.outputTimestamp see mojohaus/versions#630