Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SvelteComponentTyped is used with svelte 4 and it's deprecated #299

Open
3 tasks done
stemaDev opened this issue Jan 24, 2024 · 1 comment
Open
3 tasks done

SvelteComponentTyped is used with svelte 4 and it's deprecated #299

stemaDev opened this issue Jan 24, 2024 · 1 comment

Comments

@stemaDev
Copy link

Describe the bug

When I'm compiling, the .d.ts file includes SvelteComponentTyped which was deprecated in svelte4. I don't know if there are any differences in the object that it references behind this type, but it should be replaced with SvelteComponent instead. This way whenever I'm importing the components I get this deprecated warning.

Reproduction

https://stackblitz.com/edit/vitejs-vite-srb31p

Steps to reproduce

Create a svelte project and export a component, use the type in another project.

In the stackblitz pls delete "dist" folder and run "npm run build" and check out the .d.ts file, at the top you see the importing of a deprecated file even though the project uses svelte4

System Info

System:
    OS: Windows 10 10.0.19045
    CPU: (8) x64 Intel(R) Core(TM) i7-8565U CPU @ 1.80GHz
    Memory: 12.84 GB / 31.77 GB
  Binaries:
    Node: 18.18.1 - C:\Program Files\nodejs\node.EXE
    npm: 9.8.1 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.6.2 - ~\AppData\Local\pnpm\pnpm.EXE
  Browsers:
    Chrome: 120.0.6099.224
    Edge: Chromium (120.0.2210.144)
    Internet Explorer: 11.0.19041.3636
  npmPackages:
    vite: 5.0.11 => 5.0.11
    vite-plugin-dts: 3.7.1 => 3.7.1

Validations

@qmhc
Copy link
Owner

qmhc commented Feb 21, 2024

Will that break projects written with svelte 3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants