Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect compiler address resolution #133

Merged
merged 1 commit into from Oct 28, 2022

Conversation

rorry121
Copy link
Contributor

Hi, in vue 2.6x project, the compiler get a wrong address resolution from global node_modules but not from my project.

case:
project: vue@2.6.14
global: vue@2.7.13

It will get the global node_modules(${global}/node_modules/vue/compiler-sfc) , not from my project node_modules(${project}/node_modules/@vue/compiler-sfc)

@qmhc
Copy link
Owner

qmhc commented Oct 28, 2022

Hi, after you resolve the conflicts I will merge this PR.

@rorry121
Copy link
Contributor Author

Hi, after you resolve the conflicts I will merge this PR.

updated!

@qmhc qmhc merged commit 01cc125 into qmhc:main Oct 28, 2022
@rorry121
Copy link
Contributor Author

@qmhc There is an another problem:

─ packages(vue2.7.x)
├——package-one(vue2.6.x)
├——packages-two
├——...

The dir struct like this, when I build in package-one, It will get the complier from packages,because it will findvue/compiler-sfc by _require.resolve('vue/compiler-sfc', { paths: [compileRoot] }) first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants