Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: "preinstall": "npx only-allow pnpm" breaks application #123

Closed
DouglasCalora opened this issue Oct 6, 2022 · 8 comments
Closed
Labels
bug Something isn't working

Comments

@DouglasCalora
Copy link

I created a ts library for using in my projects using vite-plugin-dts, but in the last version of vite-plugin-dts was added "strict pnpm": https://github.com/qmhc/vite-plugin-dts/commit/05335e3da6dbb2c1724058acebcb48ffdda143a0, this breaks my apps that use my libry.

E.g., I have my libry @bildvitta/store-adapter that uses vite-plugin-dts, the apps that use @bildvitta/store-adapter are breaking because of the changes in vite-plugin-dts.

This is the error when I try to run my apps:
image

@eliasassuncao
Copy link

up

@felipegoulart
Copy link

I'm having the same problem!
Why was strict use of pnpm added?

@qmhc
Copy link
Owner

qmhc commented Oct 6, 2022

Which npm version did you use?

@qmhc qmhc added the pending Need further confirmation label Oct 6, 2022
@DouglasCalora
Copy link
Author

Which npm version did you use?

6.14.17

@eliasassuncao
Copy link

I use the version 6.14.16

@felipegoulart
Copy link

6.14.17

@qmhc
Copy link
Owner

qmhc commented Oct 6, 2022

Well, the intention of this change just to limit the package manager in this project.

This problem seems not occur in npm@8. But I will also remove the preinstall for compatibility with npm@6.

@qmhc qmhc added bug Something isn't working and removed pending Need further confirmation labels Oct 6, 2022
@DouglasCalora
Copy link
Author

Yes in npm@8 this error not happen, but this is a BREAKING CHANGE, thanks for your help!

@qmhc qmhc closed this as completed in d7167b8 Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants