Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

干掉 scss 吧! #88

Closed
nighca opened this issue Aug 31, 2018 · 15 comments · Fixed by #125
Closed

干掉 scss 吧! #88

nighca opened this issue Aug 31, 2018 · 15 comments · Fixed by #125
Assignees

Comments

@nighca
Copy link
Collaborator

nighca commented Aug 31, 2018

经常因为它导致 builder 安装失败...

@nighca nighca self-assigned this Aug 31, 2018
@doxiaodong
Copy link
Contributor

哈哈,sass 那个源码真是很难下下来,但是scss用的挺多的。

@nighca
Copy link
Collaborator Author

nighca commented Aug 31, 2018

有没有选择安装的说法?

@doxiaodong
Copy link
Contributor

不过你那里不是用 image 的么

@nighca
Copy link
Collaborator Author

nighca commented Sep 3, 2018

开发用 npm 包,发布才用 docker

@wangkechun
Copy link
Contributor

peerDependencies?

@nighca
Copy link
Collaborator Author

nighca commented Sep 3, 2018

@wangkechun 嗯,是指类似的手段,不过现在看 peerDependencies 语义上不并不是“可选”,不满足会报 warning...optionalDependencies 可能更合适一点,不过它是自动尝试去安装,而不是用户手动控制

@doxiaodong
Copy link
Contributor

可不可以 自定义一个字段,然后在 postinstall 的时候根据 config 安装

@nighca
Copy link
Collaborator Author

nighca commented Sep 3, 2018

@doxiaodong 好厉害的样子…字段值是在打 npm install 的时候指定吗

@doxiaodong
Copy link
Contributor

就是加一个命令, postinstall ,然后分析 build-config.json 里有没有 scss,less,这样的配置,然后按需安装,不过这个会安装到当前目录,怎么保证不写进当前项目的的 package.json 。

@nighca
Copy link
Collaborator Author

nighca commented Sep 3, 2018

这个做不到啊,builder 的定位目前是全局安装的

@doxiaodong
Copy link
Contributor

doxiaodong commented Sep 3, 2018

做个插件? builder-plugin-qiniu
不过好像也要有配置去配置这个插件。。

@nighca
Copy link
Collaborator Author

nighca commented Sep 4, 2018

哈哈,很牛逼了,我先改 optionalDependencies 吧,至少装不上不影响整体

@doxiaodong
Copy link
Contributor

还有 image-loader 的依赖也很难下。

@nighca
Copy link
Collaborator Author

nighca commented Sep 5, 2018

是的

@codingstar
Copy link
Contributor

codingstar commented Apr 23, 2019

我发现有个安全问题,node-sass 依赖的 node-gyp 一直不更新发布(似乎是依赖于完全放弃支持 node4 才没发布来着),有人都弃用 gulp-sass 了😂
所以我也觉得是不是可以干掉 scss 😂或者是不是可以用 sass 代替 node-sass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants