Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DockerImage could not find skbuild #10

Closed
joshi-bharat opened this issue Aug 11, 2020 · 1 comment
Closed

DockerImage could not find skbuild #10

joshi-bharat opened this issue Aug 11, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@joshi-bharat
Copy link

joshi-bharat commented Aug 11, 2020

While running the docker command, pip could not find skbuild.
Looks like skbuild is replaced with scikit-build.

Looks like it's coming from OpenCV.4.3.0 build during benchbot_api build.
Important, this is inherent in opencv-python install. Not the problem of this repo.

Just leaving here for reference.

@btalb
Copy link
Collaborator

btalb commented Aug 12, 2020

Good catch @joshi-bharat; thanks for sharing it with us here.

I was coincidentally running an installation last night which also failed with exactly the same error. The error seems to have been introduced by a version of python-opencv released in the last day or so. Your suggestion was really helpful in nailing down the root of the issue:

I have added fixes to the two places we install the API: creation of the submission Dockerfile, & installation on the host system. The fixes will likely throw the following warning when using pip:

WARNING: pip is being invoked by an old script wrapper. This will fail in a future version of pip. Please see https://github.com/pypa/pip/issues/5599 for advice on fixing the underlying issue. To avoid this problem you can invoke Python with '-m pip' instead of running pip directly.

It's just a warning, but still something I wish wasn't there. On your host system I'd recommend having a recent version of pip & some sort of virtual environment setup regardless which will also get around the warnings.

See commits 42f5ba8 & df078ba for the fixes, which are available in the v1.0.4 release. Let me know if you have any further issues.

(I'd be lying if I said I thought it was okay for something as ubiquitous as pip to require anything more than sudo apt install python3-pip to get running without issues.... but we won't go into that 😛 )

@btalb btalb closed this as completed Aug 12, 2020
@btalb btalb self-assigned this Aug 12, 2020
@btalb btalb added the bug Something isn't working label Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants