Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max limit to the indication received queue #3168

Open
KSchopmeyer opened this issue Apr 18, 2024 · 1 comment
Open

Add max limit to the indication received queue #3168

KSchopmeyer opened this issue Apr 18, 2024 · 1 comment

Comments

@KSchopmeyer
Copy link
Collaborator

Now that we have a queue to hold indications before being passed to the callbacks, the listener can overload thwat queue if indications are received at a rate faster than the callback function can process them. There should be the capability to set a maximum limit on the number of indications in the queue and either slow down acceptance or stop receiving indications.

The Python queue facility supports a Full concept for a queue so the question is exactly what should the listener do if the queue is full.

@andy-maier
Copy link
Contributor

I suggest to not enable the limit by default, but to give the user an option to opt in for the limit, because enabling the limit also means the user needs to be prepared for the exception.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants