Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_recorder.py test displays 4 logs when none should be displayed #1222

Open
KSchopmeyer opened this issue Apr 19, 2018 · 5 comments
Open
Assignees
Milestone

Comments

@KSchopmeyer
Copy link
Collaborator

KSchopmeyer commented Apr 19, 2018

Executing the test_recorder.py outputs 4 log entries but our goal is no extra output from tests. This appears to be specific to a couple of tests but these tests are covered by the log_capture and log_capture also catches these logs so there is something I do not understand yet what is going on that causes this console output of these logs other than that they are all connection log records.

@andy-maier
Copy link
Contributor

Here is the output of test_recorder.py, as of today, with 3 lines remaining:

$ py.test --ignore=attic --ignore=releases -s testsuite/test_recorder.py
================================================= test session starts ==================================================
platform darwin -- Python 2.7.15, pytest-3.8.1, py-1.6.0, pluggy-0.7.1
rootdir: /Users/maiera/Projects/other/pywbem/repos/pywbem, inifile:
plugins: cov-2.5.1
collected 53 items                                                                                                     

testsuite/test_recorder.py ..........2018-09-30 10:40:19,912-pywbem.api.1-51057-Connection:1-51057 WBEMConnection(url='http://blah', creds=None, conn_id='1-51057', default_namespace='root/cimv2', x509=None, verify_callback=None, ca_certs=None, no_verification=False, timeout=None, use_pull_operations=False, stats_enabled=False, recorders=['LogOperationRecorder'])
.2018-09-30 10:40:19,914-pywbem.api.2-51057-Connection:2-51057 WBEMConnection(url='http://blah', creds=('username', ...), conn_id='2-51057', default_namespace='root/blah', x509={'cert_file': 'Certfile.x', 'key_file': 'keyfile.x'}, verify_callback=None, ca_certs=None, no_verification=True, timeout=10, use_pull_operations=True, stats_enabled=True, recorders=['LogOperationRecorder'])
.2018-09-30 10:40:19,916-pywbem.api.3-51057-Connection:3-51057 WBEMConnection(url='http://blah', creds=('username', ...), default_namespace='root/blah', ...)
............................s............

========================================= 52 passed, 1 skipped in 2.38 seconds =========================================

@andy-maier
Copy link
Contributor

This is nothing that affects the pywbem package, or its testing. Reduced the priority to optional.

@KSchopmeyer
Copy link
Collaborator Author

I agree.

@KSchopmeyer
Copy link
Collaborator Author

Here is the output of test_recorder as of June 2021 showing no extra output.

tests/unittest/pywbem/test_perf_equality.py ..
tests/unittest/pywbem/test_recorder.py .....s..........................................................s...........
tests/unittest/pywbem/test_statistics.py ......................

I propose we close this issue

DISCOSSION Any objection to closing?

@andy-maier
Copy link
Contributor

We agreed not to close it but to try eliminating the displays.

@andy-maier andy-maier modified the milestones: 1.3.0, 1.4.0 Jul 2, 2021
@andy-maier andy-maier modified the milestones: 1.4.0, 1.5.0 Dec 31, 2021
@andy-maier andy-maier modified the milestones: 1.5.0, 1.6.0 Aug 2, 2022
@andy-maier andy-maier modified the milestones: 1.6.0, 1.7.0 Nov 29, 2022
@KSchopmeyer KSchopmeyer modified the milestones: 1.7.0, 1.8.0 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants