Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pythonic version of vtkPartitionedDataSetCollection #5377

Open
untereiner opened this issue Dec 21, 2023 · 7 comments · May be fixed by #5942 or #5487
Open

add pythonic version of vtkPartitionedDataSetCollection #5377

untereiner opened this issue Dec 21, 2023 · 7 comments · May be fixed by #5942 or #5487
Assignees
Labels
feature-request Please add this cool feature!

Comments

@untereiner
Copy link

Describe the feature you would like to be added.

vtkPartionedDataSetCollection may (or will) be an alternative to MultiBlocks. It has an companion class called vtkDataAssembly. A pythonic version for both would be very welcome.

Links to VTK Documentation, Examples, or Class Definitions.

Pseudocode or Screenshots

No response

@untereiner untereiner added the feature-request Please add this cool feature! label Dec 21, 2023
@tkoyama010 tkoyama010 self-assigned this Dec 23, 2023
@tkoyama010 tkoyama010 linked a pull request Jan 17, 2024 that will close this issue
@tkoyama010 tkoyama010 linked a pull request Jan 17, 2024 that will close this issue
@untereiner
Copy link
Author

untereiner commented Jan 31, 2024

would it be possible for plotter.add_mesh_clip_plane to clip recursively each PartitionedDataSet of the collection ?
I have also an intensive use of vtkDataAssembly to build a meaningful collection

@CharlesGueunet
Copy link

Hello @untereiner ,

We are currently investigating this issue and we will come back to you soon with more info on the subject.

@tkoyama010
Copy link
Member

First, the base class would be a PartitionedDataSet based on vtkPartitionedDataSet in my opinion. Since this would be a large addition, let's begin with a small start.

@tkoyama010
Copy link
Member

First, the base class would be a PartitionedDataSet based on vtkPartitionedDataSet in my opinion. Since this would be a large addition, let's begin with a small start.

@untereiner @CharlesGueunet I started #5833 . Please review if you want.

@CharlesGueunet
Copy link

First, the base class would be a PartitionedDataSet based on vtkPartitionedDataSet in my opinion. Since this would be a large addition, let's begin with a small start.

@untereiner @CharlesGueunet I started #5833 . Please review if you want.

Thank you ! that seems really nice. I will have a look soon. Please tell me when this is ready for review :)

@tkoyama010
Copy link
Member

First, the base class would be a PartitionedDataSet based on vtkPartitionedDataSet in my opinion. Since this would be a large addition, let's begin with a small start.

@untereiner @CharlesGueunet I started #5833 . Please review if you want.

Thank you ! that seems really nice. I will have a look soon. Please tell me when this is ready for review :)

Thank you for your comment. I have created the minimum feature for the PartitionedDataSet class in #5833, and you can now review it. If you have any requests, please comment in this thread or raise an issue.

For work efficiency, I would like to merge the minimum feature first, and then add requested functions by individual Pull Request.

After merging #5833, I will start adding PartitionedDataSetCollection class in another Pull Request.

@untereiner
Copy link
Author

@tkoyama010 Great work ! Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Please add this cool feature!
Projects
None yet
3 participants