-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Dockerfilei386 by using i386/python base image #328
Simplify Dockerfilei386 by using i386/python base image #328
Conversation
We use the docker image to build some binaries via AppVeyor. If you could please check the errors for the failing check, that would be helpful. Your point on reducing file size is awesome. |
I didn't notice that AppVeyor will be affected, will take a look and see how to deal with it. |
Looks like the |
9723dd6
to
d9b124c
Compare
Codecov Report
@@ Coverage Diff @@
## master #328 +/- ##
=======================================
Coverage 71.59% 71.59%
=======================================
Files 8 8
Lines 514 514
=======================================
Hits 368 368
Misses 146 146 Continue to review full report at Codecov.
|
@rafaelpivato should be fixed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Binary should be much smaller now.
Use
i386/python:3.6-slim
instead ofi386/ubuntu:18.04
, save the time and network bandwidth to install python, also align to Dockerfile(python:3.6-slim
), make the environment more consistent, also save the disk space and image size: