Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Dockerfilei386 by using i386/python base image #328

Merged
merged 3 commits into from
Dec 27, 2020

Conversation

PeterDaveHello
Copy link
Contributor

@PeterDaveHello PeterDaveHello commented Dec 20, 2020

Use i386/python:3.6-slim instead of i386/ubuntu:18.04, save the time and network bandwidth to install python, also align to Dockerfile(python:3.6-slim), make the environment more consistent, also save the disk space and image size:

REPOSITORY                    TAG                 IMAGE ID            CREATED             SIZE
new                           latest              a163d1c2dd4d        About an hour ago   161MB
old                           latest              1a5e52fb3e2e        11 minutes ago      485MB

@rafaelpivato rafaelpivato self-assigned this Dec 20, 2020
@rafaelpivato
Copy link
Contributor

We use the docker image to build some binaries via AppVeyor. If you could please check the errors for the failing check, that would be helpful.

Your point on reducing file size is awesome.

@PeterDaveHello
Copy link
Contributor Author

I didn't notice that AppVeyor will be affected, will take a look and see how to deal with it.

@PeterDaveHello
Copy link
Contributor Author

Looks like the binutils package is missing, I'll see not using slim image or install it manually, which one is better here.
https://pyinstaller.readthedocs.io/en/stable/requirements.html#gnu-linux

@codecov
Copy link

codecov bot commented Dec 20, 2020

Codecov Report

Merging #328 (ef50ad8) into master (4a8d983) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #328   +/-   ##
=======================================
  Coverage   71.59%   71.59%           
=======================================
  Files           8        8           
  Lines         514      514           
=======================================
  Hits          368      368           
  Misses        146      146           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a8d983...ef50ad8. Read the comment docs.

@PeterDaveHello
Copy link
Contributor Author

@rafaelpivato should be fixed now!

Copy link
Contributor

@rafaelpivato rafaelpivato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Binary should be much smaller now.

@rafaelpivato rafaelpivato merged commit b7da45f into pyupio:master Dec 27, 2020
@PeterDaveHello PeterDaveHello deleted the RefactorDockerfile branch December 27, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants