Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide CVSS information when available. #324

Merged
merged 10 commits into from
Jan 11, 2021

Conversation

nicholasks
Copy link
Contributor

This will allow Safety-CLI users to have access when CVSS information is available on meta.

And only visible when using --full-report. Here some example (not a real vuln):

Screenshot from 2020-11-22 19-42-17

@nicholasks nicholasks marked this pull request as draft November 22, 2020 22:48
@nicholasks nicholasks marked this pull request as ready for review November 22, 2020 22:54
Copy link
Contributor

@rafaelpivato rafaelpivato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicholasks can you update this from master branch, add documentation and HISTORY changes?

@codecov
Copy link

codecov bot commented Jan 10, 2021

Codecov Report

Merging #324 (23b234f) into master (b289752) will decrease coverage by 2.07%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   71.59%   69.51%   -2.08%     
==========================================
  Files           8        8              
  Lines         514      538      +24     
==========================================
+ Hits          368      374       +6     
- Misses        146      164      +18     
Impacted Files Coverage Δ
safety/formatter.py 50.87% <10.00%> (-5.42%) ⬇️
safety/safety.py 93.18% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b289752...23b234f. Read the comment docs.

@nicholasks
Copy link
Contributor Author

LGTM

@nicholasks can you update this from master branch, add documentation and HISTORY changes?

@rafaelpivato done!

@rafaelpivato rafaelpivato merged commit c60643b into pyupio:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants