Incorrect used DB #317
Merged
Incorrect used DB #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaelpivato
suggested changes
Dec 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
=======================================
Coverage 69.51% 69.51%
=======================================
Files 8 8
Lines 538 538
=======================================
Hits 374 374
Misses 164 164
Continue to review full report at Codecov.
|
@rafaelpivato done! |
rafaelpivato
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The used DB displayed is not the right when using a local DB
--dbamong with--key.Since
--dboverrides any external DB, safety should display "Using local DB" instead of "using pyup.io's DB". Users shouldn't use both parameters together but since we are displaying what was used, at least we should display the right one.