Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trollflow2 fails to launch with pyyaml 6.0 #121

Closed
gerritholl opened this issue Oct 20, 2021 · 0 comments · Fixed by #122
Closed

trollflow2 fails to launch with pyyaml 6.0 #121

gerritholl opened this issue Oct 20, 2021 · 0 comments · Fixed by #122
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@gerritholl
Copy link
Collaborator

gerritholl commented Oct 20, 2021

Describe the bug

With pyyaml 6.0, released 2021-10-13, trollflow2 satpy_launcher.py fails with TypeError if passed a logging configuration file.

To Reproduce

mamba create -n test python=3.9 pyyaml=6.0
conda activate test
pip install ~/checkouts/trollflow2
mamba install rasterio
satpy_launcher.py -n localhost ~/checkouts/pytroll-dwd-config/polar-avhrr/trollflow2.yaml -c ~/checkouts/pytroll-dwd-config/polar-avhrr/logging.yaml

Expected behavior

I expect that trollflow2 launches successfully.

Actual results

The satpy_launcher fails to start and crashes out with a TypeError:

Traceback (most recent call last):
  File "/data/gholl/mambaforge/envs/test/bin/satpy_launcher.py", line 79, in <module>
    main()
  File "/data/gholl/mambaforge/envs/test/bin/satpy_launcher.py", line 65, in main
    log_dict = yaml.load(fd.read())
TypeError: load() missing 1 required positional argument: 'Loader'

Environment Info:

  • OS: Rocky Linux 8.4
  • Trollflow2 Version: main branch (v0.10.0-29-g9f25478)

Additional context

It had been deprecated for a long time to call yaml.load(...) without passing a loader. Since pyyaml 6.0, this is no longer supported. See yaml/pyyaml#561.

@pnuu pnuu self-assigned this Oct 20, 2021
@pnuu pnuu added bug Something isn't working enhancement New feature or request labels Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants