Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against torch RC instead of nightly. Bump build version #6717

Merged
merged 2 commits into from Oct 10, 2022

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Oct 6, 2022

Test against torch RC instead of nightly. Bump build version

@atalman atalman changed the title Test against torch RC instead of nightly Test against torch RC instead of nightly. Bump build version Oct 6, 2022
@YosuaMichael
Copy link
Contributor

@atalman seems like the build failed because it can't fine pytorch 1.13.0:

conda_build.exceptions.DependencyNeedsBuildingError: Unsatisfiable dependencies for platform linux-64: {'pytorch==1.13.0'}

@atalman
Copy link
Contributor Author

atalman commented Oct 7, 2022

@atalman seems like the build failed because it can't fine pytorch 1.13.0:

conda_build.exceptions.DependencyNeedsBuildingError: Unsatisfiable dependencies for platform linux-64: {'pytorch==1.13.0'}

Yes we had an issue yesterday with missing binaries. This should be fixed now

@YosuaMichael
Copy link
Contributor

Have discussed with @atalman offline, seems like we still have problem with naming on the pytorch core binary.

@YosuaMichael
Copy link
Contributor

YosuaMichael commented Oct 7, 2022

This is related fix on pytorch core: pytorch/pytorch#86484

Use UPLOAD_CHANNEL instead of hardcoding
Copy link
Contributor

@YosuaMichael YosuaMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and all test passed now, thanks @atalman !

@YosuaMichael YosuaMichael merged commit 5ff802b into pytorch:release/0.14 Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants