Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing prototype related things from release/0.14 branch #6687

Merged
merged 8 commits into from Oct 4, 2022
Merged

Removing prototype related things from release/0.14 branch #6687

merged 8 commits into from Oct 4, 2022

Conversation

YosuaMichael
Copy link
Contributor

Removing prototype and prototype related things from the release v0.14 branch

@YosuaMichael YosuaMichael added the release-issue For release-related issues label Oct 4, 2022
@YosuaMichael YosuaMichael self-assigned this Oct 4, 2022
NicolasHug
NicolasHug approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yosua, LGTM

datumbox
datumbox approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

From what I see, the only thing missed are the expected files of prototype models that were removed but it's not affecting anything.

@YosuaMichael
Copy link
Contributor Author

Thanks for the review @NicolasHug and @datumbox !

I have removed the expect file for the depth stereo model as well, thanks for pointing this out @datumbox!

@YosuaMichael YosuaMichael merged commit 673838f into pytorch:release/0.14 Oct 4, 2022
@YosuaMichael YosuaMichael mentioned this pull request Oct 4, 2022
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasHug NicolasHug NicolasHug approved these changes

@datumbox datumbox datumbox approved these changes

Assignees

@YosuaMichael YosuaMichael

Labels
cla signed release-issue For release-related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YosuaMichael @NicolasHug @datumbox @facebook-github-bot