Set MACOSX_DEPLOYMENT_TARGET=10.9 for binary jobs #6298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
approved these changes
Jul 25, 2022
|
Hey @datumbox! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
atalman
pushed a commit
to atalman/vision
that referenced
this pull request
Jul 26, 2022
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
atalman
pushed a commit
to atalman/vision
that referenced
this pull request
Jul 26, 2022
Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
atalman
added a commit
that referenced
this pull request
Jul 26, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
Summary: Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com> Reviewed By: datumbox Differential Revision: D38154570 fbshipit-source-id: 03404d3a1f189d7d2411a68e30b23f53d0261a95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to pytorch/text#1835, thanks @mthrok for the heads up.
TL;DR: in #6218 we bumped our xcode version to v14, which led to create binaries that are only compatible with macosx_11_0 (see recent builds in https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html). For compatibility with the rest of the ecosystem, we need to keep compatibility with 10.9.
This will need to be cherry-picked in the bugfix release.
CC @atalman