Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small Patch SwinTransformer for FX compatibility #6252

Merged
merged 1 commit into from Jul 8, 2022
Merged

Small Patch SwinTransformer for FX compatibility #6252

merged 1 commit into from Jul 8, 2022

Conversation

YosuaMichael
Copy link
Contributor

Moving the padding operation of the PatchMerging component of SwinTransformer out so that it is FX compatible

The issue is raised by @ain-soph on #6246 (comment)

@YosuaMichael YosuaMichael self-assigned this Jul 8, 2022
@YosuaMichael YosuaMichael marked this pull request as ready for review July 8, 2022 16:44
@YosuaMichael YosuaMichael mentioned this pull request Jul 8, 2022
Merged
datumbox
datumbox approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Feel free to merge after green CI.

@ain-soph
Copy link
Contributor

ain-soph commented Jul 8, 2022

Seems good!

@YosuaMichael YosuaMichael mentioned this pull request Jul 8, 2022
Closed
@YosuaMichael YosuaMichael merged commit e75a333 into pytorch:main Jul 8, 2022
facebook-github-bot pushed a commit that referenced this pull request Jul 21, 2022
@NicolasHug @facebook-github-bot
[fbsync] Move out the pad operation from PatchMerging in swin transfo…
f113498 
…rmer to make it fx compatible (#6252)

Reviewed By: jdsgomes

Differential Revision: D37993420

fbshipit-source-id: 6b9dd3e161e74a00ce479a5c42376463f38a844a
@NicolasHug NicolasHug mentioned this pull request Jul 21, 2022
Closed
NicolasHug pushed a commit to NicolasHug/vision that referenced this pull request Jul 21, 2022
@YosuaMichael @NicolasHug
Move out the pad operation from PatchMerging in swin transformer to m…
4bdd088 
…ake it fx compatible (pytorch#6252)
@NicolasHug NicolasHug mentioned this pull request Jul 21, 2022
Merged
atalman pushed a commit to NicolasHug/vision that referenced this pull request Jul 26, 2022
@YosuaMichael @atalman
Move out the pad operation from PatchMerging in swin transformer to m…
d772041 
…ake it fx compatible (pytorch#6252)
atalman pushed a commit that referenced this pull request Jul 26, 2022
@NicolasHug @YosuaMichael
Small Patch SwinTransformer for FX compatibility (#6252) (#6301)
9b6233d 
* Move out the pad operation from PatchMerging in swin transformer to make it fx compatible (#6252)

* empty commmit

* empty commmit

Co-authored-by: YosuaMichael <yosuamichaelm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

Assignees

@YosuaMichael YosuaMichael

Labels
bug cla signed module: models
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YosuaMichael @ain-soph @datumbox @facebook-github-bot