Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _pil_constants.py #6154

Merged
merged 5 commits into from Jun 11, 2022
Merged

Update _pil_constants.py #6154

merged 5 commits into from Jun 11, 2022

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Jun 10, 2022

Fixes #6153

@vfdev-5 vfdev-5 marked this pull request as ready for review June 10, 2022 22:07
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a minor nit.

cc @NicolasHug, @YosuaMichael this would need to be cherrypicked into the release branch.

torchvision/transforms/_pil_constants.py Outdated Show resolved Hide resolved
@vfdev-5 vfdev-5 merged commit c02d6ce into main Jun 11, 2022
@vfdev-5 vfdev-5 deleted the fix-6153-pil-version branch June 11, 2022 09:39
datumbox added a commit to datumbox/vision that referenced this pull request Jun 11, 2022
* Update _pil_constants.py

* Update _pil_constants.py

* Fix flake8

* Fixed two related warnings in tests

* switch dir with hasattr

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
This was referenced Jun 11, 2022
datumbox added a commit that referenced this pull request Jun 11, 2022
* Update _pil_constants.py

* Update _pil_constants.py

* Fix flake8

* Fixed two related warnings in tests

* switch dir with hasattr

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>

Co-authored-by: vfdev <vfdev.5@gmail.com>
NicolasHug added a commit to NicolasHug/vision that referenced this pull request Jun 16, 2022
Summary:
* Update _pil_constants.py

* Update _pil_constants.py

* Fix flake8

* Fixed two related warnings in tests

* switch dir with hasattr

Differential Revision: D37212661

fbshipit-source-id: 4495e7a73caf1e964d17649b8408e48394a25448

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
facebook-github-bot pushed a commit that referenced this pull request Jun 17, 2022
Summary:
* Update _pil_constants.py

* Update _pil_constants.py

* Fix flake8

* Fixed two related warnings in tests

* switch dir with hasattr

Reviewed By: datumbox

Differential Revision: D37212661

fbshipit-source-id: de82b320b5d8d1a76f56dfe531678f2e81c5c3e0

Co-authored-by: Vasilis Vryniotis <datumbox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PIL version check for enum change appears to break SIMD versions
3 participants