Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No lr_scheduler in full_finetune_distributed #952

Open
jxmsML opened this issue May 8, 2024 · 1 comment
Open

No lr_scheduler in full_finetune_distributed #952

jxmsML opened this issue May 8, 2024 · 1 comment

Comments

@jxmsML
Copy link

jxmsML commented May 8, 2024

Learningrate scheduler isn't set up in the full_finetune_distributed training loop, only exists in the lora finetuning.

@jxmsML jxmsML closed this as completed May 8, 2024
@jxmsML jxmsML reopened this May 8, 2024
@ebsmothers
Copy link
Contributor

Hi @jxmsML thanks for pointing this out. We do only support fixed learning rate in the full finetune recipes, but I agree we should support schedulers there like we do in LoRA. There's not really a technical blocker for this, so if you're interested to open a PR for the feature we'd love to have it. Otherwise we hope to add it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants