Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test directory structure for models doesn't match corresponding implementation files #905

Open
ebsmothers opened this issue Apr 30, 2024 · 0 comments

Comments

@ebsmothers
Copy link
Contributor

Right now we have e.g. tests/torchtune/models/test_llama3.py and tests/torchtune/models/test_lora_llama2.py test files for our models. This is not in line with our implementation files, which have directories torchtune/models/llama2, torchtune/models/mistral, etc. We should refactor the tests/torchtune/models directory to better line up with the directory structure of torchtune/models to improve discoverability of our test files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant