[BE] Do not package caffe2 in wheel (#87986) #90433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If PyTorch is build without caffe2 integration, do not package unusable .py files/headers Same is true about functorch - don't package it unless building with `functorch` (although, I wonder if we should remove this option at some point in the future) Followup after pytorch/builder#1181 Pull Request resolved: pytorch#87986 Approved by: https://github.com/seemethere
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90433
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 FailuresAs of commit 472dba3: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If PyTorch is build without caffe2 integration, do not package unusable .py files/headers
Same is true about functorch - don't package it unless building with
functorch(although, I wonder if we should remove this option at some point in the future)Followup after pytorch/builder#1181
Pull Request resolved: #87986
Approved by: https://github.com/seemethere