Add manual cuda deps search logic (#90411) #90426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If PyTorch is package into a wheel with [nvidia-cublas-cu11](https://pypi.org/project/nvidia-cublas-cu11/), which is designated as PureLib, but `torch` wheel is not, can cause a torch_globals loading problem. Fix that by searching for `nvidia/cublas/lib/libcublas.so.11` an `nvidia/cudnn/lib/libcudnn.so.8` across all `sys.path` folders. Test plan: ``` docker pull amazonlinux:2 docker run --rm -t amazonlinux:2 bash -c 'yum install -y python3 python3-devel python3-distutils patch;python3 -m pip install torch==1.13.0;curl -OL https://patch-diff.githubusercontent.com/raw/pytorch/pytorch/pull/90411.diff; pushd /usr/local/lib64/python3.7/site-packages; patch -p1 </90411.diff; popd; python3 -c "import torch;print(torch.__version__, torch.cuda.is_available())"' ``` Fixes pytorch#88869 Pull Request resolved: pytorch#90411 Approved by: https://github.com/atalman
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90426
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Failures, 1 PendingAs of commit cff9766: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
6 tasks
albanD
reviewed
Dec 8, 2022
| nvidia_path = os.path.join(path, 'nvidia') | ||
| if not os.path.exists(nvidia_path): | ||
| continue | ||
| cublas_path = os.path.join(nvidia_path, 'cublas', 'lib', 'libcublas.so.11') |
There was a problem hiding this comment.
These are very specific lib versions. Isn't that a problem?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If PyTorch is package into a wheel with nvidia-cublas-cu11, which is designated as PureLib, but
torchwheel is not, can cause a torch_globals loading problem.Fix that by searching for
nvidia/cublas/lib/libcublas.so.11annvidia/cudnn/lib/libcudnn.so.8across allsys.pathfolders.Test plan:
Fixes #88869
Pull Request resolved: #90411
Approved by: https://github.com/atalman