Make TorchElastic timer importable on Windows (#88522) #90045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izaitsevfb
requested review from
mrshenli,
zhaojuanmao,
pritamdamania87,
rohan-varma,
H-Huang,
awgu and
kwen2501
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90045
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Failures, 1 PendingAs of commit 9c27445: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Also, add `torch.distributed` to test imports, so that we would not regress in the future Fixes pytorch#85427 Pull Request resolved: pytorch#88522 Approved by: https://github.com/d4l3k (cherry picked from commit f98edfc)
izaitsevfb
force-pushed
the
cherry-pick-release-1.13-85427
branch
from
387eb6d
to
9c27445
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick for 1.13.1
Original PR: #88522
Also, add
torch.distributedto test imports, so that we would not regress in the futureFixes #85427 Pull Request resolved: #88522 Approved by: https://github.com/d4l3k
(cherry picked from commit f98edfc)
Fixes #ISSUE_NUMBER