Mark IPU device as not supports_as_strided (#89130) #89998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently causes issues in calls to `.to`. Pull Request resolved: pytorch#89130 Approved by: https://github.com/albanD
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89998
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 FailuresAs of commit 5bf9a55: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to landed master PR (if applicable):
#89130
Criteria Category:
2: This affects correct behaviour of
IPUtensors, in the out-of-tree IPU backend.I'm hoping this is a low-risk change, since it only affects how IPU tensors are tagged, and since the IPU backend is out-of-tree, it shouldn't affect anything here.