Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform markers for linux only extra_install_requires (#88826) #89924

Merged
merged 1 commit into from Dec 6, 2022

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Nov 30, 2022

Fixes #88049

#85097 added new extra dependencies on nvidia-*. They are linux (GPU) only packages, but were not marked as such, causing issues installing pytorch 1.13 via Poetry (and possibly other tools that follow PyPI's metadata API) on non-Linux systems. This "fixes" the issue by adding the ; platform_system = 'Linux' marker on these dependencies, but the main problem of different metadata for different wheels is a somewhat larger issue.

#85097 used ; as a delimiter for splitting the different deps, but that is the delimiter used in markers, so I changed to split on |.

Pull Request resolved: #88826
Approved by: https://github.com/neersighted, https://github.com/lalmei, https://github.com/malfet

@atalman atalman requested a review from a team as a code owner November 30, 2022 17:18
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 30, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89924

Note: Links to docs will display an error until the docs builds have been completed.

❌ 9 Failures

As of commit 9336a83:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 30, 2022
Copy link
Contributor

@weiwangmeta weiwangmeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atalman atalman added ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR labels Nov 30, 2022
…8826)

Fixes pytorch#88049

pytorch#85097 added new extra dependencies on `nvidia-*`. They are linux (GPU) only packages, but were not marked as such, causing issues installing pytorch 1.13 via Poetry (and possibly other tools that follow PyPI's metadata API) on non-Linux systems. This "fixes" the issue by adding the `; platform_system = 'Linux'` marker on these dependencies, but the main problem of different metadata for different wheels is a [somewhat larger issue](pytorch#88049 (comment)).

pytorch#85097 used `;` as a delimiter for splitting the different deps, but that is the delimiter used in markers, so I changed to split on `|`.

Pull Request resolved: pytorch#88826
Approved by: https://github.com/neersighted, https://github.com/lalmei, https://github.com/malfet
@atalman atalman merged commit 029ec16 into pytorch:release/1.13 Dec 6, 2022
pytorchmergebot pushed a commit that referenced this pull request Jan 31, 2023
…3066)

Like #89924 #91083

#85097 added new extra dependencies on nvidia-*. They are linux x86_64 (GPU) only packages, but were not marked as such, causing issues installing pytorch 1.13 via Poetry (and possibly other tools that follow PyPI's metadata API) on Linux aarch64 systems. This "fixes" the issue by adding the `and platform_machine == 'x86_64'` marker on these dependencies.

Pull Request resolved: #93066
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR ciflow/binaries Trigger all binary build and upload jobs on the PR topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants