Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masked Tensor documentation is missing #89734

Closed
reconlabs-sergio opened this issue Nov 28, 2022 · 1 comment
Closed

Masked Tensor documentation is missing #89734

reconlabs-sergio opened this issue Nov 28, 2022 · 1 comment
Labels
actionable module: docs Related to our documentation, both in docs/ and docblocks module: masked operators Masked operations triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@reconlabs-sergio
Copy link

reconlabs-sergio commented Nov 28, 2022

馃摎 The doc issue

In the docs for masked tensors (https://pytorch.org/docs/stable/masked.html?highlight=masked_tensor), after the introduction, there are 4 links for:

Overview - the place to start for new users, discusses how to use MaskedTensors and why they鈥檙e useful

Sparsity - MaskedTensor supports sparse COO and CSR data and mask Tensors

Adagrad sparse semantics - a practical example of how MaskedTensor can simplify sparse semantics and implementations

Advanced semantics - discussion on why certain decisions were made (e.g. requiring masks to match for binary/reduction operations), differences with NumPy鈥檚 MaskedArray, and reduction semantics

All of these links lead to a 404 error.

The closest docs that can be found online are:

https://pytorch.org/maskedtensor/main/notebooks/overview.html

Which are outdated and do not work for the current stable version of pytorch (1.13)

Suggest a potential alternative/fix

Update and link correctly the docs.

cc @svekars @carljparker

@albanD albanD added module: docs Related to our documentation, both in docs/ and docblocks triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module actionable module: masked operators Masked operations labels Nov 28, 2022
@albanD
Copy link
Collaborator

albanD commented Nov 28, 2022

Thanks for pointing this out!
The links are indeed weirdly broken on this page... you can manually remove the .html in the linked page to get the right thing.

albanD added a commit that referenced this issue Nov 28, 2022
atalman pushed a commit to atalman/pytorch that referenced this issue Nov 30, 2022
atalman pushed a commit to atalman/pytorch that referenced this issue Nov 30, 2022
atalman added a commit that referenced this issue Nov 30, 2022
Fix #89734

Pull Request resolved: #89758
Approved by: https://github.com/anjali411, https://github.com/malfet, https://github.com/cpuhrsch

Co-authored-by: albanD <albandes@fb.com>
kulinseth pushed a commit to kulinseth/pytorch that referenced this issue Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable module: docs Related to our documentation, both in docs/ and docblocks module: masked operators Masked operations triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants