Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cuda/cpu check on NoneType (Unit test) #88970

Closed
wants to merge 1 commit into from
Closed

Fix cuda/cpu check on NoneType (Unit test) #88970

wants to merge 1 commit into from

Conversation

mikekgfb
Copy link
Contributor

Summary: Fix cuda/cpu check on NoneType (unit test)

Test Plan: sabdcastle/ github CI/CD

Differential Revision: D41208798

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88970

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 4 Pending

As of commit c7ab08b:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41228501

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41228501

@mikekgfb @facebook-github-bot
Fix cuda/cpu check on NoneType (Unit test)
c7ab08b 
Summary: Fix cuda/cpu check on NoneType (unit test)

Test Plan: sabdcastle/ github CI/CD

Differential Revision: D41208798

fbshipit-source-id: 3d55413ad8c834d5461be8627df91a76ad67cc9c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D41228501

@albanD albanD removed their request for review November 14, 2022 15:24
@mikekgfb
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 14, 2022
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@mikekgfb
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@mikekgfb mikekgfb added this to the 1.13.1 milestone Nov 15, 2022
@mikekgfb mikekgfb mentioned this pull request Nov 16, 2022
Closed
@malfet
Copy link
Contributor

malfet commented Nov 28, 2022

It would be nice to have a more detailed description on the nature of the fix and whether or not this is a regression (which is criteria for 1.13.1)

@weiwangmeta
Copy link
Contributor

Fixes: #88669

weiwangmeta pushed a commit to weiwangmeta/pytorch that referenced this pull request Nov 30, 2022
@mikekgfb @weiwangmeta
Fix cuda/cpu check on NoneType (Unit test) (pytorch#88970)
f8b06da 
Summary: Fix cuda/cpu check on NoneType (unit test)

Test Plan: sabdcastle/ github CI/CD

Differential Revision: D41208798

Pull Request resolved: pytorch#88970
Approved by: https://github.com/Skylion007, https://github.com/cpuhrsch
@weiwangmeta weiwangmeta mentioned this pull request Nov 30, 2022
Merged
@weiwangmeta weiwangmeta mentioned this pull request Nov 30, 2022
Closed
weiwangmeta pushed a commit to weiwangmeta/pytorch that referenced this pull request Dec 6, 2022
@mikekgfb @weiwangmeta
Fix cuda/cpu check on NoneType (Unit test) (pytorch#88970)
8ca09d5 
Summary: Fix cuda/cpu check on NoneType (unit test)

Test Plan: sabdcastle/ github CI/CD

Differential Revision: D41208798

Pull Request resolved: pytorch#88970
Approved by: https://github.com/Skylion007, https://github.com/cpuhrsch
atalman pushed a commit that referenced this pull request Dec 6, 2022
@weiwangmeta @mikekgfb
Fix cuda/cpu check on NoneType (Unit test) (#88970) (#89934)
be6ac74 
Summary: Fix cuda/cpu check on NoneType (unit test)

Test Plan: sabdcastle/ github CI/CD

Differential Revision: D41208798

Pull Request resolved: #88970
Approved by: https://github.com/Skylion007, https://github.com/cpuhrsch

Co-authored-by: Michael Gschwind <mikekg@meta.com>
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@mikekgfb @kulinseth
Fix cuda/cpu check on NoneType (Unit test) (pytorch#88970)
4681335 
Summary: Fix cuda/cpu check on NoneType (unit test)

Test Plan: sabdcastle/ github CI/CD

Differential Revision: D41208798

Pull Request resolved: pytorch#88970
Approved by: https://github.com/Skylion007, https://github.com/cpuhrsch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpuhrsch cpuhrsch cpuhrsch approved these changes

@Skylion007 Skylion007 Skylion007 approved these changes

@jbschlosser jbschlosser Awaiting requested review from jbschlosser

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged
Projects
None yet
Milestone
1.13.1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mikekgfb @facebook-github-bot @pytorchmergebot @malfet @weiwangmeta @cpuhrsch @Skylion007