Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_default_qat_qconfig for PT 1.13 #88876

Closed
wants to merge 4 commits into from
Closed

Fix get_default_qat_qconfig for PT 1.13 #88876

wants to merge 4 commits into from

Conversation

peterjc123
Copy link
Collaborator

@peterjc123 peterjc123 commented Nov 11, 2022 •
edited by pytorch-bot bot

@peterjc123
Fix get_default_qat_qconfig for PT 1.13
6c669b0 
Seehttps://github.com//pull/84329/files#r1019916766 for more context
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 11, 2022 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88876

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 23c2bf0:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 11, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot added the oncall: quantization Quantization support in PyTorch label Nov 11, 2022
jgong5
jgong5 approved these changes Nov 11, 2022
View reviewed changes
Copy link
Collaborator

@jgong5 jgong5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tests to avoid such issues in the future?

@peterjc123
Copy link
Collaborator Author

peterjc123 commented Nov 12, 2022 •
edited

@jgong5 I'm glad to add a test but I don't know where to put them.

@jerryzh168
Copy link
Contributor

jerryzh168 commented Nov 12, 2022 •
edited

you can add tests here: https://github.com/pytorch/pytorch/blob/master/test/quantization/core/test_top_level_apis.py as a separate TestCase like TestQConfig or something I think, this feels like a big problem, but probably we are not using version == 0 since version defaults to 1 so it's doesn't impact current use cases much

@peterjc123
Copy link
Collaborator Author

@jerryzh168 @jgong5 Test added.

@peterjc123
Copy link
Collaborator Author

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 15, 2022
@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approval needed from one of the following (Rule 'superuser'):
teng-li, Babar, Krovatkin, manuelcandales, hlin09, ...

Details for Dev Infra team Raised by workflow job

@peterjc123 peterjc123 requested review from z-a-f, jerryzh168 and vkuzo and removed request for vkuzo, z-a-f and jerryzh168 November 15, 2022 02:05
@peterjc123
Copy link
Collaborator Author

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@peterjc123 peterjc123 deleted the fix_default_qat_qconfig_for_pt13 branch November 15, 2022 11:30
@malfet malfet added this to the 1.13.1 milestone Nov 17, 2022
weiwangmeta pushed a commit to weiwangmeta/pytorch that referenced this pull request Nov 30, 2022
@peterjc123 @weiwangmeta
Fix get_default_qat_qconfig for PT 1.13 (pytorch#88876)
22f6103 
See https://github.com/pytorch/pytorch/pull/84329/files#r1019916766 for more context

Pull Request resolved: pytorch#88876
Approved by: https://github.com/jgong5, https://github.com/vkuzo
This was referenced Nov 30, 2022
Merged
Closed
weiwangmeta pushed a commit to weiwangmeta/pytorch that referenced this pull request Dec 6, 2022
@peterjc123 @weiwangmeta
Fix get_default_qat_qconfig for PT 1.13 (pytorch#88876)
05fb43b 
See https://github.com/pytorch/pytorch/pull/84329/files#r1019916766 for more context

Pull Request resolved: pytorch#88876
Approved by: https://github.com/jgong5, https://github.com/vkuzo
atalman pushed a commit that referenced this pull request Dec 6, 2022
@weiwangmeta @peterjc123
Fix get_default_qat_qconfig for PT 1.13 (#88876) (#89931)
97a3bc7 
See https://github.com/pytorch/pytorch/pull/84329/files#r1019916766 for more context

Pull Request resolved: #88876
Approved by: https://github.com/jgong5, https://github.com/vkuzo

Co-authored-by: peterjc123 <peterghost86@gmail.com>
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@peterjc123 @kulinseth
Fix get_default_qat_qconfig for PT 1.13 (pytorch#88876)
7524206 
See https://github.com/pytorch/pytorch/pull/84329/files#r1019916766 for more context

Pull Request resolved: pytorch#88876
Approved by: https://github.com/jgong5, https://github.com/vkuzo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkuzo vkuzo vkuzo approved these changes

@jgong5 jgong5 jgong5 approved these changes

@Xia-Weiwen Xia-Weiwen Awaiting requested review from Xia-Weiwen

@z-a-f z-a-f Awaiting requested review from z-a-f

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: quantization Quantization support in PyTorch open source release notes: AO frontend
Projects
None yet
Milestone
1.13.1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@peterjc123 @jerryzh168 @pytorchmergebot @vkuzo @jgong5 @malfet @pytorchbot