[BE] Do not package caffe2 in wheel #87986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87986
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d7ce594: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
seemethere
approved these changes
Oct 28, 2022
If PyTorch is build without caffe2 integration, do not package unusable .py files/headers Followup after pytorch/builder#1181
malfet
force-pushed
the
malfet/do-not-package-caffe2
branch
from
a41e9be
to
d763e08
Compare
malfet
force-pushed
the
malfet/do-not-package-caffe2
branch
from
d763e08
to
4e8ae96
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: The following mandatory check(s) failed (Rule Dig deeper by viewing the failures on hud Details for Dev Infra teamRaised by workflow job |
Why don't we do wheels, like on other platforms
malfet
changed the title
|
@pytorchbot merge -f "This is a build only change" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
ashay
added a commit
to llvm/torch-mlir
that referenced
this pull request
Nov 4, 2022
Unless requested otherwise, PyTorch no longer installs most of the header files under the caffe2 directory (see pytorch/pytorch#87986). This breaks our importer code since we need to use the `MakeGuard()` function to execute statements in the event of exceptions. To fix this issue, this patch implements a rudimentary version of PyTorch's ScopeGuard, where once the class variable goes out of scope, it executes a predefined method.
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
If PyTorch is build without caffe2 integration, do not package unusable .py files/headers Same is true about functorch - don't package it unless building with `functorch` (although, I wonder if we should remove this option at some point in the future) Followup after pytorch/builder#1181 Pull Request resolved: pytorch#87986 Approved by: https://github.com/seemethere
atalman
pushed a commit
to atalman/pytorch
that referenced
this pull request
Dec 8, 2022
If PyTorch is build without caffe2 integration, do not package unusable .py files/headers Same is true about functorch - don't package it unless building with `functorch` (although, I wonder if we should remove this option at some point in the future) Followup after pytorch/builder#1181 Pull Request resolved: pytorch#87986 Approved by: https://github.com/seemethere
atalman
pushed a commit
to atalman/pytorch
that referenced
this pull request
Dec 8, 2022
If PyTorch is build without caffe2 integration, do not package unusable .py files/headers Same is true about functorch - don't package it unless building with `functorch` (although, I wonder if we should remove this option at some point in the future) Followup after pytorch/builder#1181 Pull Request resolved: pytorch#87986 Approved by: https://github.com/seemethere
This was referenced Dec 8, 2022
atalman
added a commit
that referenced
this pull request
Dec 8, 2022
If PyTorch is build without caffe2 integration, do not package unusable .py files/headers Same is true about functorch - don't package it unless building with `functorch` (although, I wonder if we should remove this option at some point in the future) Followup after pytorch/builder#1181 Pull Request resolved: #87986 Approved by: https://github.com/seemethere Co-authored-by: Nikita Shulga <nshulga@meta.com>
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
If PyTorch is build without caffe2 integration, do not package unusable .py files/headers Same is true about functorch - don't package it unless building with `functorch` (although, I wonder if we should remove this option at some point in the future) Followup after pytorch/builder#1181 Pull Request resolved: pytorch#87986 Approved by: https://github.com/seemethere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If PyTorch is build without caffe2 integration, do not package unusable
.py files/headers
Same is true about functorch - don't package it unless building with
functorch(although, I wonder if we should remove this option at some point in the future)Followup after pytorch/builder#1181