[JIT] Imbue stringbuf with C locale (#79929) #79983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To prevent 12345 become "12,345" if locale is not "C", as shown in the
following example:
```cpp
int main() {
std::locale::global(std::locale("en_US.utf-8"));
std::stringstream ss;
ss << "12345 in " << std::locale().name() << " locale is " << 12345 ;
ss.imbue(std::locale("C"));
ss << " but in C locale is " << 12345;
std::cout << ss.str() << std::endl;
}
```
Fixes pytorch#79583
Pull Request resolved: pytorch#79929
Approved by: https://github.com/davidberard98
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 84bd906 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: jit
ngimel
approved these changes
Jun 21, 2022
seemethere
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent 12345 become "12,345" if locale is not "C", as shown in the
following example:
Fixes #79583
Pull Request resolved: #79929
Approved by: https://github.com/davidberard98