[JIT] Imbue stringbuf with C locale #79929
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful links
❌ 5 New Failures, 2 Base FailuresAs of commit 05f28af (more details on the Dr. CI page): Expand to see more
🕵️ 5 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
facebook-github-bot
added
the
oncall: jit
davidberard98
approved these changes
Jun 21, 2022
To prevent 12345 become "12,345" if locale is not "C", as shown in the
following example:
```cpp
int main() {
std::locale::global(std::locale("en_US.utf-8"));
std::stringstream ss;
ss << "12345 in " << std::locale().name() << " locale is " << 12345 ;
ss.imbue(std::locale("C"));
ss << " but in C locale is " << 12345;
std::cout << ss.str() << std::endl;
}
```
malfet
force-pushed
the
malfet/ir-imbue-with-C-locale
branch
from
17db387
to
05f28af
Compare
malfet
added
the
ciflow/binaries_wheel
|
pip installing https://gha-artifacts.s3.amazonaws.com/pytorch/pytorch/2533367977/manywheel-py3_7-cuda11_6/torch-1.13.0.dev20220621%2Bcu116-cp37-cp37m-linux_x86_64.whl shows that problem is indeed gone |
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Merge failed due to Refusing to merge as mandatory check(s) pull failed for rule superuser |
|
@pytorchbot merge -f |
|
@pytorchbot successfully started a merge job. Check the current status here |
|
Hey @malfet. |
malfet
added
release notes: jit
atalman
pushed a commit
to atalman/pytorch
that referenced
this pull request
Jun 21, 2022
To prevent 12345 become "12,345" if locale is not "C", as shown in the
following example:
```cpp
int main() {
std::locale::global(std::locale("en_US.utf-8"));
std::stringstream ss;
ss << "12345 in " << std::locale().name() << " locale is " << 12345 ;
ss.imbue(std::locale("C"));
ss << " but in C locale is " << 12345;
std::cout << ss.str() << std::endl;
}
```
Fixes pytorch#79583
Pull Request resolved: pytorch#79929
Approved by: https://github.com/davidberard98
This was referenced Jun 21, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
Summary:
To prevent 12345 become "12,345" if locale is not "C", as shown in the
following example:
```cpp
int main() {
std::locale::global(std::locale("en_US.utf-8"));
std::stringstream ss;
ss << "12345 in " << std::locale().name() << " locale is " << 12345 ;
ss.imbue(std::locale("C"));
ss << " but in C locale is " << 12345;
std::cout << ss.str() << std::endl;
}
```
Fixes #79583
Pull Request resolved: #79929
Approved by: https://github.com/davidberard98
Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/4b6ba340e211503b758ea6c3c173e1e7bbd9c11c
Reviewed By: atalman
Differential Revision: D37316875
Pulled By: malfet
fbshipit-source-id: d3900f532930850bd4973274c3274cf31d8b8d09
atalman
added a commit
that referenced
this pull request
Jun 22, 2022
To prevent 12345 become "12,345" if locale is not "C", as shown in the
following example:
```cpp
int main() {
std::locale::global(std::locale("en_US.utf-8"));
std::stringstream ss;
ss << "12345 in " << std::locale().name() << " locale is " << 12345 ;
ss.imbue(std::locale("C"));
ss << " but in C locale is " << 12345;
std::cout << ss.str() << std::endl;
}
```
Fixes #79583
Pull Request resolved: #79929
Approved by: https://github.com/davidberard98
Co-authored-by: Nikita Shulga <nshulga@fb.com>
miladm
pushed a commit
to miladm/pytorch
that referenced
this pull request
Jun 27, 2022
To prevent 12345 become "12,345" if locale is not "C", as shown in the
following example:
```cpp
int main() {
std::locale::global(std::locale("en_US.utf-8"));
std::stringstream ss;
ss << "12345 in " << std::locale().name() << " locale is " << 12345 ;
ss.imbue(std::locale("C"));
ss << " but in C locale is " << 12345;
std::cout << ss.str() << std::endl;
}
```
Fixes pytorch#79583
Pull Request resolved: pytorch#79929
Approved by: https://github.com/davidberard98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent 12345 become "12,345" if locale is not "C", as shown in the
following example:
Fixes #79583