Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.12] nn: Disable nested tensor by default #79884

Merged

Conversation

seemethere
Copy link
Member

Better transformers (and by extension nested tensor) are identified as a
prototype feature and should not be enabled by default for the 1.12
release.

Signed-off-by: Eli Uriegas eliuriegas@fb.com

Better transformers (and by extension nested tensor) are identified as a
prototype feature and should not be enabled by default for the 1.12
release.

Signed-off-by: Eli Uriegas <eliuriegas@fb.com>
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 20, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 9c12526 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@seemethere seemethere changed the title nn: Disable nested tensor by default [release/1.12] nn: Disable nested tensor by default Jun 20, 2022
@erichan1 erichan1 self-requested a review June 20, 2022 20:04
Copy link
Member

@erichan1 erichan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting up the PR! Looks good.

@seemethere seemethere marked this pull request as ready for review June 20, 2022 20:06
@seemethere seemethere requested a review from a team June 20, 2022 20:08
@atalman atalman merged commit 01d9324 into release/1.12 Jun 20, 2022
@github-actions github-actions bot deleted the seemethere/disable_nested_tensor_by_default_112 branch February 17, 2024 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants