Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release doc builds #79865

Closed
wants to merge 2 commits into from
Closed

Fix release doc builds #79865

wants to merge 2 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Jun 20, 2022

This logic were lost during last workflow migration and as result we do not have docs builds for 1.12 release candidate, see pytorch/pytorch.github.io/tree/site/docs

Hattip to @brianjo for reminding me about the issue

@malfet
Fix release tagged builds
e11339a 
This logic were lost during last workflow migration and as result we do not have docs builds for 1.12 release candidate, see pytorch/pytorch.github.io/tree/site/docs 

Hattip to @brianjo for reminding me about the issue
@malfet malfet added module: ci Related to continuous integration module: doc infra Related to pytorch.org/docs, deployment of, and serving labels Jun 20, 2022
@malfet malfet added this to the 1.12.0 milestone Jun 20, 2022
@malfet malfet requested a review from a team as a code owner June 20, 2022 13:56
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 20, 2022 •
edited

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit bf316e3 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@malfet malfet requested a review from suo June 20, 2022 14:01
@malfet malfet changed the title Fix release tagged builds Fix release doc builds Jun 20, 2022
atalman
atalman approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atalman
Copy link
Contributor

atalman commented Jun 20, 2022

please fix lint before merging

@seemethere
Copy link
Member

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@malfet
Copy link
Contributor Author

malfet commented Jun 20, 2022

@pytorchbot merge -f

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

malfet added a commit that referenced this pull request Jun 20, 2022
@malfet
Fix release doc builds (#79865)
5009086 
This logic were lost during last workflow migration and as result we do not have docs builds for 1.12 release candidate, see pytorch/pytorch.github.io/tree/site/docs

Hattip to @brianjo for reminding me about the issue

Pull Request resolved: #79865
Approved by: https://github.com/atalman, https://github.com/albanD, https://github.com/seemethere

(cherry picked from commit 2bfba84)
@malfet malfet mentioned this pull request Jun 20, 2022
Closed
facebook-github-bot pushed a commit that referenced this pull request Jun 21, 2022
@malfet @facebook-github-bot
Fix release doc builds (#79865) (#79865)
361e740 
Summary:
This logic were lost during last workflow migration and as result we do not have docs builds for 1.12 release candidate, see pytorch/pytorch.github.io/tree/site/docs

Hattip to brianjo for reminding me about the issue

Pull Request resolved: #79865
Approved by: https://github.com/atalman, https://github.com/albanD, https://github.com/seemethere

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/2bfba840847e785b4da56498041421fc4929826b

Reviewed By: atalman

Differential Revision: D37311402

Pulled By: malfet

fbshipit-source-id: 8b55fdcb180fb4c0a38efdda6e90d9d21a6b2cf6
miladm pushed a commit to miladm/pytorch that referenced this pull request Jun 27, 2022
@malfet @miladm
Fix release doc builds (pytorch#79865)
7e52324 
This logic were lost during last workflow migration and as result we do not have docs builds for 1.12 release candidate, see pytorch/pytorch.github.io/tree/site/docs

Hattip to @brianjo for reminding me about the issue

Pull Request resolved: pytorch#79865
Approved by: https://github.com/atalman, https://github.com/albanD, https://github.com/seemethere
@malfet malfet deleted the malfet-patch-16 branch July 17, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemethere seemethere seemethere approved these changes

@albanD albanD albanD approved these changes

@atalman atalman atalman approved these changes

@suo suo Awaiting requested review from suo

Assignees
No one assigned
Labels
cla signed Merged module: ci Related to continuous integration module: doc infra Related to pytorch.org/docs, deployment of, and serving
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@malfet @facebook-github-bot @atalman @seemethere @pytorchmergebot @albanD